2010YOUY01 commented on PR #24519: URL: https://github.com/apache/datafusion/pull/24519#issuecomment-5357837022
Thank you! This PR does 1) perf 2) fix float +0.0 and -0.0 normalization, right? I have some thoughts on the zero normalization part: Is it possible to add an optimizer rule, to rewrite the expression like `match_condition t1.v1 < t2.v1` --> `match_condition normalize_zero(t1.v1) < normalize_zero(t2.v1)` , and this way we can move the complexity outside the operators. Other implementations seem can also benefit: https://github.com/apache/datafusion/pull/22835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
