2010YOUY01 commented on PR #24519: URL: https://github.com/apache/datafusion/pull/24519#issuecomment-5384136469
I see, this makes sense to me. One extra challenge is how should we keep the +- 0.0 handling consistent in the entire project, and make this approach documented somewhere, otherwise different implementations will handle it differently https://github.com/apache/datafusion/pull/22835 Regarding the optimization part, I suggest we can wait until SQL and benchmark is done for https://github.com/apache/datafusion/pull/23738. Though this PR should be strictly better in performance, but we might be able to find some more aggressive optimization that need to structure the code differently, and it's easier to review when the benchmark is ready. Ideally we can proceed with a smaller fix-only PR right now, maybe https://github.com/apache/datafusion/pull/24375 from @Xuanwo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
