jayzhan211 commented on PR #24519: URL: https://github.com/apache/datafusion/pull/24519#issuecomment-5395051915
#24375 looks overkill for me. > I see, this makes sense to me. One extra challenge is how should we keep the +- 0.0 handling consistent in the entire project, and make this approach documented somewhere, otherwise different implementations will handle it differently https://github.com/apache/datafusion/pull/22835 Another idea that came to mind is to make this a trait method on ExecutionPlan, so whether to apply this conversion can be configurable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
