0lai0 commented on PR #5300:
URL:
https://github.com/apache/datafusion-comet/pull/5300#issuecomment-5381589796
Thanks @andygrove, all four addressed on the branch.
- Added Performance (tuned ...) rows for #5233 and this PR to
collection_funcs.md, and updated the two matching rows in
optimizing_expressions.md
- Removed, along with the cast_with_options / CastOptions imports. Kept a
defensive if !matches!(..., Int32) guard so a future new list type routed here
fails loud.
- Resolved by the merge from main (#5395's rewrite_nulls_to_minus_one
refactor). spark_size_large_list_from_offsets no longer forks locally.
- Added test_spark_size_large_list_array_no_nulls and
test_spark_size_large_list_checked_span_overflow_rows_fit with [0, i32::MAX,
i32::MAX + 10] → [i32::MAX, 10].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
