0lai0 commented on PR #5300: URL: https://github.com/apache/datafusion-comet/pull/5300#issuecomment-5455061262
Thanks @andygrove. PR updated: 1. Audit doc: collapsed the three `spark_size` performance bullets into one that describes the current implementation, with the PR links kept as references. 2. Hard error: That trade is deliberate. Fail loudly rather than silently paying for a cast we do not expect. `LargeList` is the only Int64 producer and is already on the offset path, so a cast here would be dead code. A future Arrow type change should fail the existing tests at the dependency bump rather than hide behind a fallback. Added that wording to the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
