alamb commented on PR #15591: URL: https://github.com/apache/datafusion/pull/15591#issuecomment-5400931576
> @rluvaton @alamb @Dandandan > > I’m actually more concerned about the implementation complexity, especially for complex types—the work required just to extract the trait was already quite painful. > > I’m somewhat less concerned about the performance impact. Based on the benchmarks that have been run throughout this PR, the regression appears relatively modest, ranging from roughly neutral to around 10%. However, I think we would likely reject a PR that has a 10% slowdown on some aggregates (it is a core feature of DataFusion) I agree the complexity is wild -- that is why I am trying to help @2010YOUY01 refactor the aggregate streams so it is actually possible (and maybe more plausible to implement it incrementally) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
