2010YOUY01 commented on PR #15591: URL: https://github.com/apache/datafusion/pull/15591#issuecomment-5419284871
> my implementation ditched the emit to first and emit all and instead only have emit next block, since it will simplify implementations to not have enums and a lot of generics like this PR have to support both > > The problem with that is that this is breaking change that cannot be done incrementally, like, all the helpers can be created in different pr, but changing to blocked implementation cannot be done incremently. Based on my previous experiments, I agree with using only `EmitTo::NextBlock`, and I also think it would be challenging to roll this out incrementally. I can participate asynchronously by reviewing PoC PRs. Given the complexity of the implementation, I think we’ll need to look at the actual code to make meaningful progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
