rluvaton commented on PR #15591: URL: https://github.com/apache/datafusion/pull/15591#issuecomment-5409636846
@2010YOUY01 So I started implementing locally blocked for multi group by and was able to implement it with something I'm comfortable, but the added helpers are where the complexity exists, those helpers are also seems useful to be in arrow my implementation ditched the emit to first and emit all and instead only have emit next block, since it will simplify implementations to not have enums and a lot of generics like this PR have to support both The problem with that is that this is breaking change that cannot be done incrementally, like, all the helpers can be created in different pr, but changing to blocked implementation cannot be done incremently. I would like to jump on a call with you two and discuss this further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
