geoffreyclaude commented on PR #24526: URL: https://github.com/apache/datafusion/pull/24526#issuecomment-5422600129
> FYI I think @geoffreyclaude has many optimizations for IN list in flight > > * [Further improve performance of IN list evaluation #19241](https://github.com/apache/datafusion/issues/19241) > > @geoffreyclaude can you help review this PR and let me know if it conflicts with what you have planned? > > (BTW @sunchao is the original author of the arrow-rs parquet reader, one of the original contributors of DataFusion Comet, and a long time friend of the project) Thanks for the ping @alamb. I took a high level look at this and I don't see any conflict with #19241: rather it's complimentary as @viirya noted. There might indeed be opportunities for factorizing common code, but that should probably be done once both streams are committed and stable to avoid annoying conflicts. I'll do a more in-depth pass on the PR and see if there are any in-line comments to make. But overall it looks really nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
