milenkovicm commented on code in PR #2393:
URL:
https://github.com/apache/datafusion-ballista/pull/2393#discussion_r3886071784
##########
ballista/executor/src/executor.rs:
##########
@@ -269,7 +282,7 @@ impl Executor {
stage_id: usize,
task_id: usize,
) -> Result<bool, BallistaError> {
- if let Some((_, handle)) = self.abort_handles.remove(&TaskKey {
+ if let Some(handle) = self.abort_handles.get(&TaskKey {
Review Comment:
why do we need to change from `remove` to `get` why cant we remove the
handle if task is cancelled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
