milenkovicm commented on code in PR #2393:
URL:
https://github.com/apache/datafusion-ballista/pull/2393#discussion_r3890326545
##########
ballista/executor/src/executor.rs:
##########
@@ -269,7 +282,8 @@ impl Executor {
stage_id: usize,
task_id: usize,
) -> Result<bool, BallistaError> {
- if let Some((_, handle)) = self.abort_handles.remove(&TaskKey {
+ // Keep the handle registered until execute_query_stage finishes
cleanup.
+ if let Some(handle) = self.abort_handles.get(&TaskKey {
Review Comment:
i believe task ower there will return error, at the cancellation and cleanup
/ remove would be performed there ? Am I correct? if I am, please update this
comment adding those details, also please add comment over there so that there
is dependency to `cancel_task`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
