goutamadwant commented on code in PR #24492:
URL: https://github.com/apache/datafusion/pull/24492#discussion_r3887195015
##########
datafusion/ffi/src/session/mod.rs:
##########
@@ -117,12 +115,6 @@ pub(crate) struct FFI_SessionRef {
logical_plan_serialized: SVec<u8>,
) -> FFI_Result<SVec<u8>>,
- create_physical_plan:
Review Comment:
@kosiew Addressed in latest changes. I restored `create_physical_plan` at
its exact original position and signature in `FFI_SessionRef`, including
initialization through the construction and clone paths. The retained callback
now returns `NotImplemented` without invoking the installed planner, preserving
the DataFusion 55 layout and preventing shifted function-pointer calls. Let me
know if this is good now. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
