goutamadwant commented on code in PR #24492:
URL: https://github.com/apache/datafusion/pull/24492#discussion_r3887197481
##########
datafusion/ffi/src/session/mod.rs:
##########
@@ -1014,35 +974,33 @@ mod tests {
Ok(())
}
- /// `create_physical_plan` must serialize with the session's logical codec
on
- /// both sides of the boundary. A plan that scans a custom table provider
is
- /// unserializable without it.
#[tokio::test]
- async fn test_create_physical_plan_uses_logical_codec() -> Result<(),
DataFusionError>
- {
- let (ctx, task_ctx_provider) =
crate::util::tests::test_session_and_ctx();
-
- let schema = Arc::new(Schema::new(vec![Field::new("a",
DataType::Int32, true)]));
- let batch = record_batch!(("a", Int32, [1, 2, 3]))?;
- let table = MemTable::try_new(schema, vec![vec![batch]])?;
- ctx.register_table("test_table", Arc::new(table))?;
+ async fn test_foreign_session_rejects_create_physical_plan() {
Review Comment:
@kosiew I extended the existing three-library `dlopen` planner-swap
integration test to verify that direct foreign-session delegation returns
`DataFusionError::NotImplemented`, then continues through the captured
`FFI_QueryPlanner` and successfully reconstructs local, downcastable
execution-plan nodes. The unit regression also invokes the retained callback
directly and verifies zero planner re-entry. Hope this covers it. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
