adriangb commented on PR #22908: URL: https://github.com/apache/datafusion/pull/22908#issuecomment-5469828372
One thing I pointed out to Andrew on a call but that was maybe never recorded here: a lot of the functions in `datafusion_functions_json` like `json_get_int` exist so that the structure `select (col->'key')::int` can be optimized to avoid extra intermediate steps and instruct the parser to materialize directly into an `int` or null. They are not necessarily meant to be exposed publicly, although because of crate structures and such we probably do have to make all of these functions public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
