dwsmith1983 commented on code in PR #5565:
URL: https://github.com/apache/datafusion-comet/pull/5565#discussion_r3895692712
##########
native/shuffle/src/ipc.rs:
##########
@@ -15,23 +15,65 @@
// specific language governing permissions and limitations
// under the License.
+use crate::codec_context::ShuffleDecodeContext;
use arrow::array::RecordBatch;
use arrow::ipc::reader::StreamReader;
use datafusion::common::DataFusionError;
use datafusion::error::Result;
+use std::cell::RefCell;
use std::io::{Error, ErrorKind, Read};
+thread_local! {
Review Comment:
Done — the scan operator owns the decode context now (on the exec rather
than the stream since the decode loop runs exec-side, where JNI calls are
allowed; retention still dies with the operator). The thread-local is down to
one production caller, the static decodeShuffleBlock entry, and the _with
variants have a real caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
