dwsmith1983 commented on code in PR #5565:
URL: https://github.com/apache/datafusion-comet/pull/5565#discussion_r3895724664
##########
native/shuffle/src/shuffle_writer.rs:
##########
@@ -577,6 +566,56 @@ mod test {
repartitioner.insert_batch(batch.clone()).await.unwrap();
}
+ /// The zstd context is reused within one encode burst but must not
survive past it: a
+ /// spill event and the final shuffle write each end with the context
released.
+ #[tokio::test]
+ #[cfg_attr(miri, ignore)] // miri can't call foreign function
`ZSTD_createCCtx`
+ async fn local_writer_releases_zstd_context_at_burst_boundaries() {
Review Comment:
Added the counter, test-gated on both context types. The burst test asserts
exactly one creation across a two-partition spill burst and two after the
finish burst, and the boundary tests from your other comment use the same
counter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
