dwsmith1983 commented on code in PR #5565:
URL: https://github.com/apache/datafusion-comet/pull/5565#discussion_r3895714241
##########
native/shuffle/src/writers/shuffle_block_writer.rs:
##########
@@ -269,9 +273,52 @@ impl ShuffleBlockWriter {
// write header
output.write_all(&self.header_bytes)?;
+ let encode_result =
Review Comment:
I looked at a lifetime reservation: the pusher contract treats reserve,
push, and release as one synchronous invocation with a single outstanding
reservation, and release takes no amount, so a standing charge would need the
JNI contract extended on both sides. Kept RSS per-invocation (same cost as
main) and updated the description so it no longer reads as if both paths
benefit. Happy to look at extending the pusher contract as a follow-up if there
is appetite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
