gabotechs commented on code in PR #24826:
URL: https://github.com/apache/datafusion/pull/24826#discussion_r3896621849
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -1951,11 +1965,16 @@ impl PhysicalProtoConverterExtension for
DeduplicatingProtoConverter {
/// A PhysicalExtensionCodec that tries one of multiple inner codecs
/// until one works
+#[deprecated(
+ since = "56.0.0",
+ note = "Please use `ComposedNamedPhysicalExtensionCodec`"
+)]
Review Comment:
Still not sure if it's worth to deprecate this one, FWIW both could live
together.
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -2058,6 +2078,146 @@ impl PhysicalExtensionCodec for
ComposedPhysicalExtensionCodec {
}
}
+/// A PhysicalExtensionCodec that tries one of multiple inner codecs until one
works.
+/// The name of the codec that successfully encoded an [`ExecutionPlan`] is
stored in the
+/// encoded payload, and the codec with that exact name will be used for
decoding.
+#[derive(Default, Debug)]
+pub struct ComposedNamedPhysicalExtensionCodec {
+ codecs: HashMap<Cow<'static, str>, Arc<dyn PhysicalExtensionCodec>>,
+}
Review Comment:
cc @milenkovicm, do you have any opinions about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
