kosiew commented on code in PR #24853:
URL: https://github.com/apache/datafusion/pull/24853#discussion_r3950839810
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -8130,10 +8196,37 @@ mod tests {
self.emit_counts(emit_to)
}
+ fn evaluate_preserving(
Review Comment:
I don't think we need the new preserving-read overrides for this test.
`SingleHashAggregateStream` reaches `evaluate(EmitTo::All)` through the shared
terminal helper, so this path doesn't call `evaluate_preserving` or
`state_preserving`. Could we remove those methods and their support flags? The
default trait implementations should be enough here, and that would keep the
fixture focused on catching destructive `EmitTo::First` usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
