hhhizzz commented on code in PR #24853:
URL: https://github.com/apache/datafusion/pull/24853#discussion_r3951448711
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -8130,10 +8196,37 @@ mod tests {
self.emit_counts(emit_to)
}
+ fn evaluate_preserving(
Review Comment:
Thanks @kosiew, agreed. Removed both preserving-read overrides, their
support flags, and the unused `GroupSelection` import in
f2aaae70eba03ef4336f516eaa397b7199658e27. The fixture now uses the trait
defaults and stays focused on rejecting destructive `EmitTo::First`.
The targeted grouped-aggregation tests, extended workspace test suite, and
full `./dev/rust_lint.sh` checks all pass. I also updated the PR description to
match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
