mbutrovich commented on PR #5853: URL: https://github.com/apache/datafusion-comet/pull/5853#issuecomment-5639950938
> A few suggestions below. None of them need to block this PR, and they are fine as a follow-up. > > **`fill_delete_file_sizes` stats Puffin files it never needs.** `IcebergScanExec::fill_delete_file_sizes` in `native/core/src/execution/operators/iceberg_scan.rs` stats every unique delete path per Spark partition. iceberg-rust only uses `file_size_in_bytes` in `parquet_to_batch_stream`, and the DV path does a range read from `content_offset` without touching the size. Could we skip Puffin entries when building `needed`? On S3 that is one HEAD per Puffin file per partition for nothing. That one is a real problem. I fixed it. Thanks for the review, @andygrove! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
