andygrove opened a new pull request, #863: URL: https://github.com/apache/datafusion-comet/pull/863
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Related to https://github.com/apache/datafusion-comet/issues/798 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Add benchmarks to show performance of disabling native scan and converting spark columnst to Comet (currently performed via converting to row first). ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - Remove `SPARK_GENERATE_BENCHMARK_FILES=1` from documentation because we have no such feature (there is no other reference to this env var in our codebase as far as I can tell) - Add new combination to existing benchmarks ## How are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ``` AMD Ryzen 9 7950X3D 16-Core Processor TPCDS Snappy: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ q3: Spark Scan + Spark Exec 159 171 14 182.8 5.5 1.0X q3: Comet Scan + Spark Exec 182 201 13 159.2 6.3 0.9X q3: Comet Scan + Comet Exec 216 240 17 134.2 7.5 0.7X q3: Spark Scan + Comet Exec 450 458 9 64.4 15.5 0.4X ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
