andygrove commented on code in PR #863:
URL: https://github.com/apache/datafusion-comet/pull/863#discussion_r1728217474
##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometTPCDSMicroBenchmark.scala:
##########
@@ -104,15 +104,27 @@ object CometTPCDSMicroBenchmark extends
CometTPCQueryBenchmarkBase {
}
val numRows = queryRelations.map(tableSizes.getOrElse(_, 0L)).sum
val benchmark = new Benchmark(benchmarkName, numRows, 2, output = output)
- benchmark.addCase(s"$name$nameSuffix") { _ =>
+ benchmark.addCase(s"$name$nameSuffix: Spark Scan + Spark Exec") { _ =>
cometSpark.sql(queryString).noop()
}
- benchmark.addCase(s"$name$nameSuffix: Comet (Scan)") { _ =>
+ benchmark.addCase(s"$name$nameSuffix: Comet Scan + Spark Exec") { _ =>
withSQLConf(CometConf.COMET_ENABLED.key -> "true") {
cometSpark.sql(queryString).noop()
}
}
- benchmark.addCase(s"$name$nameSuffix: Comet (Scan, Exec)") { _ =>
+ benchmark.addCase(s"$name$nameSuffix: Comet Scan + Comet Exec") { _ =>
Review Comment:
Sure, I can switch back to more consistent naming with the existing tests
for this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
