mbutrovich commented on code in PR #863:
URL: https://github.com/apache/datafusion-comet/pull/863#discussion_r1727002602
##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometAggregateBenchmark.scala:
##########
@@ -28,7 +28,7 @@ import org.apache.comet.CometConf
/**
* Benchmark to measure Comet execution performance. To run this benchmark:
* {{{
- * SPARK_GENERATE_BENCHMARK_FILES=1 make
benchmark-org.apache.spark.sql.benchmark.CometAggregateBenchmark
+ * make benchmark-org.apache.spark.sql.benchmark.CometAggregateBenchmark
Review Comment:
This looks like it was just an old config that wasn't doing anything anymore?
##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometTPCDSMicroBenchmark.scala:
##########
@@ -104,15 +104,27 @@ object CometTPCDSMicroBenchmark extends
CometTPCQueryBenchmarkBase {
}
val numRows = queryRelations.map(tableSizes.getOrElse(_, 0L)).sum
val benchmark = new Benchmark(benchmarkName, numRows, 2, output = output)
- benchmark.addCase(s"$name$nameSuffix") { _ =>
+ benchmark.addCase(s"$name$nameSuffix: Spark Scan + Spark Exec") { _ =>
cometSpark.sql(queryString).noop()
}
- benchmark.addCase(s"$name$nameSuffix: Comet (Scan)") { _ =>
+ benchmark.addCase(s"$name$nameSuffix: Comet Scan + Spark Exec") { _ =>
withSQLConf(CometConf.COMET_ENABLED.key -> "true") {
cometSpark.sql(queryString).noop()
}
}
- benchmark.addCase(s"$name$nameSuffix: Comet (Scan, Exec)") { _ =>
+ benchmark.addCase(s"$name$nameSuffix: Comet Scan + Comet Exec") { _ =>
Review Comment:
I'm not sure this is the PR to blow up the diff with a refactor, but we may
consider standardizing this terminology (`Comet (Scan, Exec)` vs. `Comet Scan +
Comet Exec`) for searching the code base for test/benchmark cases or downstream
processing of the benchmark output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
