adragomir commented on PR #25342: URL: https://github.com/apache/datafusion/pull/25342#issuecomment-5695305814
@adriangb looks good, I understand the difference and the addition for the Map type. I can confirm that I have tested this with our entire test (nothing fancy, just a test on a nested predicate on a large delta table with nested schema), and it still passes correctly - the benchmark return numbers in the ballpark. Personally, I would minimize churn - like minimizing the changes to minimize the patch, and just treat the Map stuff using the new function, but that's not related to functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
