adriangb commented on PR #25342: URL: https://github.com/apache/datafusion/pull/25342#issuecomment-5699122690
@adragomir I looked for ways to minimize the diff / churn but all of the changes here seem worth it. In particular on keeping main's structure and only routing Map through a new function, that would mean keeping the throwaway single-field Schema built per nested level (that's the 17285 → 5588 ns in https://github.com/apache/datafusion/pull/25342#discussion_r4027087595, and it would stay on the slow side). The unreachable match arm that was the single uncovered line in [#25193](https://github.com/pydantic/datafusion/issues/25193)'s codecov report, and the name-matching that map entries can't use anyway (Map has to come out of that grouped or-pattern either way, since its children match by position). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
