dwsmith1983 commented on PR #5867: URL: https://github.com/apache/datafusion-comet/pull/5867#issuecomment-5731843512
> Are you both happy for this PR to carry the map-lookup serde, with any non-overlapping coverage from #5875 rebased on top once it lands? Yes, happy for this PR to carry the map-lookup serde. The `size`, `array_append`, `arrays_zip` and `map_from_arrays` fix has no counterpart in #5875, so rebasing its extra fixtures and benchmark cases on top once this lands is the smaller move. One sequencing note: if #5854 lands first, its native `map_from_arrays` replaces the `LAST_WIN` decline this PR wraps, and the gate here becomes the fallback chain peterxcli described on that PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
