hassaanch23 commented on PR #25400: URL: https://github.com/apache/datafusion/pull/25400#issuecomment-5732242122
I merged `main` to resolve the conflict with #25402, which also edits `AggregateExprBuilder::build()`. Both changes now sit in one expression: - An order-insensitive aggregate's ORDER BY is cleared (#25402). - Otherwise, repeated sort keys are dropped through `LexOrdering` (this PR). Against `main`, the change is now just that `else` branch plus the import. The new `aggregate.slt` cases still fail with the duplicate-key removal disabled, and pass with it. The full sqllogictest suite, the `aggregate` unit tests and clippy (all targets) pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
