dwsmith1983 commented on PR #5654: URL: https://github.com/apache/datafusion-comet/pull/5654#issuecomment-5732301622
> Thanks @dwsmith1983 @ErikBPF, folks, WDYT to proceed with #5786 to patch physical scans and then check what cases are still not addressed in this field and fix pursue them in this PR? > > The initial reason I was slightly concerned is 2k LOC to patch an extreme scenario We can cut it down. The footer check's reason to exist went away with #6004, so I can drop it and its tests, which takes out the reader-factory and the Rust test bulk. What stays is the adapter raising Spark's error for an ambiguous requested id, last-wins exact names, the id shield and typed errors through the JNI cause chain, none of which #5786 covers. On order, #5786 currently does not type-check against main per @sunchao and would reject the DataFusion-written file you showed on #6004, so I would still land this first and let #5786 rebase onto the smaller diff. Does that work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
