dwsmith1983 commented on PR #6041: URL: https://github.com/apache/datafusion-comet/pull/6041#issuecomment-5746943362
> Could it also account for `spark.sql.codegen.factoryMode=NO_CODEGEN`? Done in 6db6c1b27. The guard now reads the factory mode the way `CollapseCodegenStages.apply` does, so `NO_CODEGEN` counts as codegen off, and the regression adds a variant under that setting in both ANSI modes. Without the check that variant fails with Comet recovering 0.6 where Spark latches. The compatibility note lists the mode with the other planning-time cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
