dwsmith1983 commented on PR #6041: URL: https://github.com/apache/datafusion-comet/pull/6041#issuecomment-5750587636
Pushed 674df28f4 after a closer read of `CollapseCodegenStages.supportCodegen`: a non-leaf `CodegenFallback` expression anywhere in the aggregate's expressions also turns codegen off, and Comet converts several of those natively (`filter(array(...), x -> ...)` for one), so the guard now mirrors that predicate. Tests cover both the result-expression and FILTER-clause shapes, plus ungrouped object hash aggregate and `SUM(DISTINCT)` coverage, and the compatibility note now names the two runtime fallbacks (`spark.sql.codegen.fallback`, `spark.sql.codegen.hugeMethodLimit`) that a plan-time guard cannot see. `CometAggregateSuite` and `CometWindowExecSuite` pass on Spark 3.5, and the change compiles against 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
