martin-g commented on code in PR #25404:
URL: https://github.com/apache/datafusion/pull/25404#discussion_r4061688036
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -3129,12 +3134,18 @@ pub struct TableScan {
pub filters: Vec<Expr>,
/// Optional number of rows to read
pub fetch: Option<usize>,
+ /// Optional number of rows to skip
+ pub offset: Option<usize>,
Review Comment:
Done with
https://github.com/apache/datafusion/pull/25404/commits/5786305eff6d1cb0780e786d89c285d71f981b4f
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -517,11 +544,13 @@ impl LogicalPlanBuilder {
projection: Option<Vec<usize>>,
filters: Vec<Expr>,
fetch: Option<usize>,
+ offset: Option<usize>,
) -> Result<Self> {
let table_scan = TableScanBuilder::new(table_name, table_source)
.with_projection(projection)
.with_filters(filters)
.with_fetch(fetch)
+ .with_offset(offset)
Review Comment:
Done with
https://github.com/apache/datafusion/pull/25404/commits/4de77e9cf9e00d3eab36ec9c2eb8f89953887405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
