pepijnve commented on code in PR #25404:
URL: https://github.com/apache/datafusion/pull/25404#discussion_r4060792565
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -517,11 +544,13 @@ impl LogicalPlanBuilder {
projection: Option<Vec<usize>>,
filters: Vec<Expr>,
fetch: Option<usize>,
+ offset: Option<usize>,
) -> Result<Self> {
let table_scan = TableScanBuilder::new(table_name, table_source)
.with_projection(projection)
.with_filters(filters)
.with_fetch(fetch)
+ .with_offset(offset)
Review Comment:
It might be useful to add somewhere in the documentation what the expected
order of offset/fetch wrt filters is. I assume it's the SQL order of filtering
then offset/limit, but I think it would still be useful to make this explicit.
Maybe a short note on the fields of TableScan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
