pepijnve commented on code in PR #25112:
URL: https://github.com/apache/datafusion/pull/25112#discussion_r4071007062


##########
datafusion/core/tests/sql/create_drop.rs:
##########
@@ -89,3 +113,105 @@ async fn create_drop_table() -> Result<()> {
 
     Ok(())
 }
+
+#[tokio::test]
+async fn create_external_catalog_with_factory() -> Result<()> {
+    let mut state = SessionStateBuilder::new().with_default_features().build();

Review Comment:
   I've gone ahead and done this already, and while I was at it changed 
`SessiontStateBuilder::with_table_factory` to accept `impl Into<String>` as 
well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to