pepijnve commented on code in PR #25112:
URL: https://github.com/apache/datafusion/pull/25112#discussion_r4071570370
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1043,6 +1063,49 @@ impl SessionContext {
}
}
+ async fn create_external_catalog(
+ &self,
+ cmd: &CreateExternalCatalog,
+ ) -> Result<DataFrame> {
+ let exists = self.catalog(cmd.catalog_name.as_str()).is_some();
+
+ match (cmd.if_not_exists, cmd.or_replace, exists) {
+ (true, false, true) => self.return_empty_dataframe(),
+ (true, true, true) => {
+ exec_err!("'IF NOT EXISTS' cannot coexist with 'REPLACE'")
+ }
+ (false, false, true) => {
+ exec_err!("External catalog '{}' already exists",
cmd.catalog_name)
+ }
+ (_, _, _) => {
+ let new_catalog = self.create_custom_catalog(cmd).await?;
+ self.state
+ .write()
+ .catalog_list()
+ .register_catalog(cmd.catalog_name.clone(), new_catalog);
+ self.return_empty_dataframe()
+ }
+ }
+ }
+
+ async fn create_custom_catalog(
+ &self,
+ cmd: &CreateExternalCatalog,
+ ) -> Result<Arc<dyn CatalogProvider>> {
+ let state = self.state.read().clone();
+ let catalog_type = cmd.catalog_type.to_uppercase();
Review Comment:
This is mirroring what `create_custom_table` is doing. Fair question if this
is wanted or not especially since the internal hash table can be acquired
mutably so we can't control all inserts into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
