pepijnve commented on code in PR #25112:
URL: https://github.com/apache/datafusion/pull/25112#discussion_r4071608016
##########
datafusion/session/src/catalog.rs:
##########
@@ -233,6 +254,17 @@ impl dyn CatalogProviderList {
}
}
+/// A factory which creates [`CatalogProvider`]s at runtime given a URL.
Review Comment:
Another case of following the existing patterns:
```
/// A factory which creates [`TableProvider`]s at runtime given a URL.
```
Should I adapt both? I guess the intention was to refer to the location as
the primary input rather than all the secondary bits that are in the command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
