osipovartem commented on PR #25373: URL: https://github.com/apache/datafusion/pull/25373#issuecomment-5790614502
Independent review found that the initial struct fast path could bypass a user-registered `ExprPlanner` for the custom `:` operator. I rebased the branch onto current `main` and fixed the planner precedence: - custom binary planners are consulted exactly once before the built-in struct `get_field` fallback; - a planner-returned `RawBinaryExpr` is preserved through fallback; - the existing vectorized struct path remains unchanged when no custom planner handles the operator; - added a regression test where a custom colon planner receives a struct operand. Focused verification passed: all `expr_planner` integration tests (5/5), relevant struct SQLLogicTests (4 files), `cargo fmt --all`, and `cargo clippy -p datafusion-sql -- -D warnings`. A separate read-only re-review found no remaining blockers and explicitly approved the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
