martin-g commented on PR #25112: URL: https://github.com/apache/datafusion/pull/25112#issuecomment-5810913861
> I think we should just use CREATE CATALOG consistently in our docs / examples 👍🏻 But `CREATE DATABASE ...` is already in the wild, so it has to be supported. > I think this pR is ready to go now -- and we can iterate on it in follow on PRs. Any other thoughts before we merge @pepijnve or @martin-g ? IMO it would be good to add a simple SLT to document/verify that they are synonyms: ``` statement ok CREATE EXTERNAL DATABASE abc; -- uses DATABASE statement ok DROP CATALOG abc; -- uses CATALOG ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
