pepijnve commented on PR #25112: URL: https://github.com/apache/datafusion/pull/25112#issuecomment-5813377902
> > I think we should just use CREATE CATALOG consistently in our docs / examples > > 👍🏻 But `CREATE DATABASE ...` is already in the wild, so it has to be supported. We can keep `CREATE DATABASE` support as is as an alias for `CREATE CATALOG`. And then use `CREATE CATALOG` everywhere in the documentation. The added benefit of using `catalog.schema.table` is that this maps nicely to the equivalent types in DataFusion. > > I think this pR is ready to go now -- and we can iterate on it in follow on PRs. Any other thoughts before we merge @pepijnve or @martin-g ? I have the cascade part you requested ready locally, was just waiting on clarification regarding the direction. I'll finish that and add it to this PR. > IMO it would be good to add a simple SLT to document/verify that they are synonyms: > > ``` > statement ok > CREATE EXTERNAL DATABASE abc; -- uses DATABASE > ``` I'm not inclined to add `CREATE EXTERNAL DATABASE` support due to the inconsistent use of `DATABASE` across systems this is just going to be confusing. We can add a plain `CREATE DATABASE` test though to cover what you have in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
