TinyMurky commented on PR #25497: URL: https://github.com/apache/datafusion/pull/25497#issuecomment-5830309356
Hello @jayzhan211 ! Thank you for spending time reviewing my pr! I have added the following tests to the original pr. First I added `ordered_array_agg_does_not_coalesce_large_payloads` as you mention above. https://github.com/apache/datafusion/blob/d6c4d8b5e4ddd33313ce9eb7b4c7104a8bb5fd29/datafusion/functions-aggregate/src/array_agg.rs#L3035-L3059 Then I separated `ordered_array_agg_coalesces_dictionary_and_view_payloads` into two different tests: - `ordered_array_agg_sorts_across_coalesced_utf8_view_batches` https://github.com/apache/datafusion/blob/d6c4d8b5e4ddd33313ce9eb7b4c7104a8bb5fd29/datafusion/functions-aggregate/src/array_agg.rs#L3061-L3108 - `ordered_array_agg_sorts_across_coalesced_dictionary_batches` https://github.com/apache/datafusion/blob/d6c4d8b5e4ddd33313ce9eb7b4c7104a8bb5fd29/datafusion/functions-aggregate/src/array_agg.rs#L3110-L3163 Could you review these tests? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
