TinyMurky commented on code in PR #25497: URL: https://github.com/apache/datafusion/pull/25497#discussion_r4111977161
########## datafusion/functions-aggregate/src/array_agg.rs: ########## Review Comment: I had run benchmark on following commits and updated the PR description : - 6a792c67 : `main` - 8588db18 : this pr before updating detach copy skip - 19564841 : this pr after updating change <!-- obsidian --> Benchmark | main 6a792c67 (µs) | PR 8588db18 (µs) | PR 19564841 (µs) -- | -- | -- | -- i64 ordered，1 row/update | 1,527.20 | 3,494.10 | 779.37 i64 random，1 row/update | 2,207.60 | 2,051.30 | 1,052.50 i64 ordered，8 rows/update | 221.42 | 258.73 | 133.85 i64 random，8 rows/update | 454.68 | 494.41 | 363.10 i64 ordered，64 rows/update | 50.37 | 50.37 | 50.44 i64 random，64 rows/update | 258.03 | 258.29 | 262.51 i64 ordered，2,048 rows/update | 18.68 | 19.09 | 19.00 i64 random，2,048 rows/update | 228.52 | 234.06 | 236.29 Utf8 4 KiB，1 row/update（update_batches only） | 2,417.90 | 2,442.10 | 2,642.90 the code that I edited in the new commit was as below，and it would skip `compact_view_after_concat` too, because the `compact_payload()` would be called during small batches merged if `DataType` is `Utf8View` or `BinaryView` and it followed small batches conditions. https://github.com/apache/datafusion/blob/c92bbc919cf78ab3d48b72f1040d1a681ba7d4c8/datafusion/functions-aggregate/src/array_agg.rs#L1527-L1583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
