kosiew commented on code in PR #25825: URL: https://github.com/apache/datafusion/pull/25825#discussion_r4228049425
########## datafusion/sqllogictest/test_files/aggregate_memory_spill.slt: ########## @@ -61,7 +61,7 @@ FROM ( ) ---- <slt:ignore> -04)------AggregateExec: mode=Single, gby=[v@0 * 7 % 100000 as t.v * Int64(7) % Int64(100000)], aggr=[sum(t.v)], metrics=[<slt:ignore>spill_count=7,<slt:ignore>] +04)------AggregateExec: mode=Single, gby=[v@0 * 7 % 100000 as t.v * Int64(7) % Int64(100000)], aggr=[sum(t.v)], metrics=[<slt:ignore>spill_count=<slt:ignore>] Review Comment: Replacing `spill_count=7` with `spill_count=<slt:ignore>` means this test now passes even when no spilling occurs. The same issue affects cases B through F. Could you keep a positive-spill check, either by updating the expected counts from actual runs or using another supported assertion that verifies spilling? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
