Samearth17 commented on PR #6671: URL: https://github.com/apache/datafusion-comet/pull/6671#issuecomment-6093816701
Addressed the review by moving the end-to-end cast coverage into `cast_duplicate_struct_fields.sql`. The fixture exercises duplicate targets through direct struct, array-of-struct, and map-value struct casts with the expected fallback reason, plus a distinct-name native-path control. The low-level recursive `CometCast.isSupported` checks remain in the Scala suite. Validation: `./mvnw spotless:check -DskipTests` passed and `git diff --check` passed. Focused native SQL execution is unavailable in this macOS checkout because no Comet native library is built under `native/target/*-apple-darwin`; CI will provide that end-to-end check. Pushed head: `e112b0f045815bf0f8e4103a0b4db9c68655518c`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
