viirya commented on issue #6434: URL: https://github.com/apache/datafusion-comet/issues/6434#issuecomment-6111818544
This is done: - #6435 split the JVM exception raising into a JNI-free classification (`NativeError`) and a JNI throw step, and moved the logic of `isFeatureEnabled`, `isObjectStoreSchemeSupported` and the shuffle block decoding into core functions. - #6534 did the same for the remaining entry points that do not call back into the JVM: columnar-to-row conversion, the sorted shuffle file writer, partition sorting, shuffle partition offsets, `NativeBase.init` and `getTzdataVersion`. - #6695 did it for the plan entry points (`createPlan`, `setShufflePartitionPusher`, `executePlan`, `releasePlan`), passing the steps that need a JNI `Env` in as callbacks, so a plan can be created, run and released in a Rust unit test. The remaining exports (`columnarToRowInit`/`columnarToRowClose`, `NativeBase.release`, the tracing entry points and `getRustThreadId`) already only call JNI-free functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
