siddubakka commented on code in PR #26164: URL: https://github.com/apache/datafusion/pull/26164#discussion_r4261178082
########## datafusion/sqllogictest/test_files/issue_25978.slt: ########## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +########## +# Regression test for https://github.com/apache/datafusion/issues/25978 +# A GROUP BY aggregate over a UNION ALL fails to plan when one branch +# projects coalesce(<nullable boolean expression>, FALSE). +# The CSE optimizer rewrites this into an AND/OR pattern whose +# nullability was incorrectly reported, causing a physical vs logical +# schema mismatch. +########## + +statement ok +CREATE TABLE a (k VARCHAR NOT NULL, x VARCHAR) AS VALUES ('k1', 'y'), ('k2', NULL); Review Comment: done, moved it over to aggregate.slt and dropped the separate file. same queries, tables get cleaned up at the end -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
