dwsmith1983 commented on code in PR #6838:
URL: https://github.com/apache/datafusion-comet/pull/6838#discussion_r4266261947
##########
spark/src/main/scala/org/apache/comet/objectstore/NativeConfig.scala:
##########
@@ -123,6 +123,15 @@ object NativeConfig {
}
}
+ /**
+ * The schemes native reads through libhdfs: the `fs.comet.libhdfs.schemes`
list, or only `hdfs`
+ * when it is unset or blank, as native `is_hdfs_scheme` decides.
+ */
+ def resolveLibhdfsSchemes(hadoopConf: Configuration): Set[String] = {
Review Comment:
Made it `private[comet]`. Outside the tests its callers are `CometScanRule`
and `DeltaScanSupport`, both under `org.apache.comet`, and no Java code calls
it, so it needs no public forwarder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
