dwsmith1983 commented on code in PR #6838:
URL: https://github.com/apache/datafusion-comet/pull/6838#discussion_r4266277932
##########
contrib/delta-spark/src/test/scala/org/apache/comet/contrib/delta/DeltaScanContribSuite.scala:
##########
@@ -252,11 +254,71 @@ class DeltaScanContribSuite extends CometDeltaTestBase {
assert(DeltaScanSupport.s3CompliantAliasSchemeReason(notOptedIn,
Seq(blobUri)).isEmpty)
}
- test("libhdfsSchemes parses the list exactly like core's scan gate (trim,
lowercase, blanks)") {
- withSQLConf(CometConf.COMET_LIBHDFS_SCHEMES.key -> " HDFS , viewfs ,, ") {
- assert(DeltaScanSupport.libhdfsSchemes == Set("hdfs", "viewfs"))
+ test("scheme gate claims a scheme listed in the Hadoop conf's
libhdfs.schemes") {
Review Comment:
One test now writes the Delta table once and plans the three variants
against it. The `isNativelyReadableScheme` precondition is gone, and the list
is plain `fake,hdfs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
