KonaeAkira opened a new pull request, #26365:
URL: https://github.com/apache/datafusion/pull/26365

   ## Which issue does this PR close?
   
   - Related to #16367.
   
   ## Rationale for this change
   
   Allows for configuring the zstd compression level for spill files instead of 
always using arrow's default compression level (3). Possible now that arrow-rs 
exposes `IpcWriteOptions::try_with_compression_level`.
   
   ## What changes are included in this PR?
   
   - `SpillCompression::Zstd` becomes `SpillCompression::Zstd(u32)` with 
`SpillCompression::DEFAULT_ZSTD_LEVEL = 3`.
   - `datafusion.execution.spill_compression` accepts `zstd(<level>)` with a 
level in 0..=22, parsed and validated at `SET` time. Plain `zstd` means level 3 
to preserve current behavior.
   
   ## What is the testing strategy for this PR?
   
   - 2 new parse tests in `datafusion/common/src/config.rs`.
   - 1 new test in `datafusion/physical-plan/src/spill/mod.rs` to assert that 
setting zstd compression level actually changes compression behavior.
   - sqllogictests in 
`datafusion/sqllogictest/test_files/information_schema.slt`.
   
   ## Are there any user-facing changes?
   
   Yes, breaking change because `SpillCompression` is a public enum. Added an 
upgrade guide to `docs/source/library-user-guide/upgrading/56.0.0.md`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to