github-actions[bot] commented on PR #26365: URL: https://github.com/apache/datafusion/pull/26365#issuecomment-6191102524
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.1.0 (current) Built [ 58.358s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.032s] (current) Building datafusion v55.1.0 (baseline) Built [ 56.812s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.638s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 118.237s] datafusion Building datafusion-common v55.1.0 (current) Built [ 33.217s] (current) Parsing datafusion-common v55.1.0 (current) Parsed [ 0.065s] (current) Building datafusion-common v55.1.0 (baseline) Built [ 33.287s] (baseline) Parsing datafusion-common v55.1.0 (baseline) Parsed [ 0.066s] (baseline) Checking datafusion-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.795s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip --- failure enum_discriminants_undefined_non_unit_variant: enum's variants no longer have defined discriminants due to non-unit variant --- Description: An enum's variants no longer have well-defined discriminant values due to a tuple or struct variant in the enum. This breaks downstream code that accesses discriminants via a numeric cast like `as isize`. ref: https://doc.rust-lang.org/reference/items/enumerations.html#assigning-discriminant-values impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_discriminants_undefined_non_unit_variant.ron Failed in: enum SpillCompression in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:546 --- failure enum_unit_variant_changed_kind: An enum unit variant changed kind --- Description: A public enum's exhaustive unit variant has changed to a different kind of enum variant, breaking possible instantiations and patterns. ref: https://doc.rust-lang.org/reference/items/enumerations.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_unit_variant_changed_kind.ron Failed in: variant SpillCompression::Zstd in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:548 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 68.772s] datafusion-common Building datafusion-physical-plan v55.1.0 (current) Built [ 35.904s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.183s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 35.647s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.181s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.649s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 73.847s] datafusion-physical-plan Building datafusion-sqllogictest v55.1.0 (current) Built [ 93.498s] (current) Parsing datafusion-sqllogictest v55.1.0 (current) Parsed [ 0.015s] (current) Building datafusion-sqllogictest v55.1.0 (baseline) Built [ 93.737s] (baseline) Parsing datafusion-sqllogictest v55.1.0 (baseline) Parsed [ 0.016s] (baseline) Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.105s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 189.980s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
