0lai0 commented on PR #5932: URL: https://github.com/apache/datafusion-comet/pull/5932#issuecomment-6194156426
Merging main also extracted the serde body into `buildNativeScanCommon`, which contrib/delta-spark's CometDeltaNativeScan also calls, so setIgnoreVariantAnnotation now covers the Delta arm. That is the behavior it should have had: before, Delta took the proto default and would raise `_LEGACY_ERROR_TEMP_3071` on Spark versions whose converter has no variant branch at all. 893 tests pass, clippy and fmt clean, `./mvnw -DskipTests` compile green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
